lostluck commented on code in PR #35089:
URL: https://github.com/apache/beam/pull/35089#discussion_r2116231965
##########
sdks/go/pkg/beam/runners/prism/internal/engine/elementmanager.go:
##########
@@ -1648,6 +1648,10 @@ keysPerBundle:
continue
}
holdsInBundle[e.holdTimestamp]++
+ if e.timestamp > watermark {
Review Comment:
I mean, we have popped the arbitrary timer `e` off the heap. We see that
it's time hasn't come.
Then we break out of the loop.
e is now lost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
