lostluck commented on code in PR #35991:
URL: https://github.com/apache/beam/pull/35991#discussion_r2307554683
##########
sdks/go/pkg/beam/runners/prism/internal/execute.go:
##########
@@ -95,7 +96,7 @@ func RunPipeline(j *jobservices.Job) {
j.SendMsg("pipeline completed " + j.String())
j.SendMsg("terminating " + j.String())
- j.Done()
+ j.PendingDone = true
Review Comment:
I recommend a method on Job for this instead, and using an atomic. The write
and read are good to be in different goroutines and that's it's own race
condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
