shunping commented on code in PR #35991:
URL: https://github.com/apache/beam/pull/35991#discussion_r2307818461
##########
sdks/go/pkg/beam/runners/prism/internal/worker/worker.go:
##########
@@ -727,6 +732,10 @@ func NewMultiplexW(lis net.Listener, g *grpc.Server,
logger *slog.Logger) *Multi
func (mw *MultiplexW) MakeWorker(id, env string) *W {
mw.mu.Lock()
defer mw.mu.Unlock()
+ jobId := strings.TrimSuffix(id, "_"+env)
Review Comment:
> so this is adding it a second time.
I am actually removing the suffix to get the job id.
The id input parameter for MakeWorker is actually the jobId + "_" + env, and
I have extracted that out.
##########
sdks/go/pkg/beam/runners/prism/internal/worker/worker.go:
##########
@@ -727,6 +732,10 @@ func NewMultiplexW(lis net.Listener, g *grpc.Server,
logger *slog.Logger) *Multi
func (mw *MultiplexW) MakeWorker(id, env string) *W {
mw.mu.Lock()
defer mw.mu.Unlock()
+ jobId := strings.TrimSuffix(id, "_"+env)
Review Comment:
> so this is adding it a second time.
I am actually removing the suffix to get the job id.
The id input parameter for MakeWorker is actually the jobId + "_" + env, and
I have extracted that out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
