shunping commented on code in PR #35991:
URL: https://github.com/apache/beam/pull/35991#discussion_r2307968968
##########
sdks/go/pkg/beam/runners/prism/internal/worker/worker.go:
##########
@@ -727,6 +732,10 @@ func NewMultiplexW(lis net.Listener, g *grpc.Server,
logger *slog.Logger) *Multi
func (mw *MultiplexW) MakeWorker(id, env string) *W {
mw.mu.Lock()
defer mw.mu.Unlock()
+ jobId := strings.TrimSuffix(id, "_"+env)
Review Comment:
> That means you can easily change all the callsites if we need to.
Yea, I agree that taking the jobID as the input parameter in MakeWorker
would be clearer solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
