sjvanrossum opened a new pull request, #36834: URL: https://github.com/apache/beam/pull/36834
Continuing from #36075, this PR removes support for old Kafka client libraries, requiring at least Kafka 2.8.2 or newer. Note that every version of Kafka <4.0.0 still supports [API protocol versions <0.10.0](https://kafka.apache.org/41/documentation/compatibility.html#p-compatibility) and the compatibility matrix indicates that versions of Kafka >=3.0.0 would provide the best compatibility in combination with versions of Kafka >=4.0.0. I've got another change to the poll loop queued up that leverages features only available in versions of Kafka >=3.0.0, so I'll address that compatibility bit in a following PR. This PR leverages the `Admin` client to request end offsets without creating buffers like `Consumer` clients do. Profiling showed that `Admin` clients used 10% of the memory that was used by `Consumer` clients for end offset requests. The `Admin` client returns a `KafkaFuture` for every request which is fulfilled by an IO thread managed by the Kafka client library, thus restoring the background thread feature that was removed in #36075. I intend to backport this change to `KafkaUnboundedReader` in a separate PR. ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier). To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md) GitHub Actions Tests Status (on master branch) ------------------------------------------------------------------------------------------------ [](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule) See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
