sjvanrossum commented on PR #36834:
URL: https://github.com/apache/beam/pull/36834#issuecomment-3541427183

   Note that this change may break `KafkaIO` configurations with complex 
`Consumer` factories. A `Consumer` factory should not be used to alter the 
environment (a `JvmInitializer` is more fitting) or configuration (a 
configuration supplier property should be added).  I'm actually thinking we 
should keep the existing implementation alongside the new and check if users 
have provided a custom `Consumer` factory and only use the new implementation 
when that isn't the case.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to