gemini-code-assist[bot] commented on PR #36834: URL: https://github.com/apache/beam/pull/36834#issuecomment-3541121120
## Summary of Changes Hello @sjvanrossum, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the KafkaIO connector by upgrading the minimum supported Kafka client version and refactoring how end offsets are retrieved. By switching from the Consumer client to the more efficient Admin client for offset requests, the change significantly improves memory performance and reintroduces asynchronous background processing for these operations. This update ensures better resource utilization and aligns the connector with more recent Kafka client capabilities. ### Highlights * **Kafka Version Upgrade**: The minimum required Kafka client library version has been updated to 2.8.2 or newer, removing support for older versions (2.0.1, 2.3.1, 2.4.1, 2.5.1). * **Memory Efficiency Improvement**: The KafkaIO connector now leverages the Kafka Admin client instead of the Consumer client for requesting end offsets. This change significantly reduces memory usage, with profiling showing a 90% reduction for end offset requests. * **Restored Background Thread Feature**: The Admin client returns a KafkaFuture for each request, which is fulfilled by an I/O thread managed by the Kafka client library. This restores the background thread feature for offset requests that was previously removed. * **API Modernization**: New methods like `withAdminFactoryFn` have been added to `KafkaIO.Read` and `KafkaIO.ReadSourceDescriptors` to allow users to provide a custom Admin client factory, enhancing flexibility and supporting different Kafka Admin versions. <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
