aIbrahiim commented on code in PR #37685:
URL: https://github.com/apache/beam/pull/37685#discussion_r2843401557
##########
sdks/python/setup.py:
##########
@@ -549,8 +552,13 @@ def get_portability_package_data():
] + ml_base,
'p312_ml_test': [
'datatable',
+ 'namex==0.0.9',
Review Comment:
@damccorm Agreed, using ranges instead of exact pins i updated to
namex>=0.0.9,<0.2.0 and optree>=0.16.0,<0.19.0 so these constrain the resolver
and avoid resolution too deep while still allowing minor updates if we hit
resolver or compatibility issues we can narrow further
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -3169,9 +3170,21 @@ class BeamModulePlugin implements Plugin<Project> {
packages += ",${extra}"
}
+ def pythonSdkDir = project.project(":sdks:python").projectDir
+ // Python 3.13 requires numpy>=2.1.0; constraints.txt pins numpy<2
for py310-312.
+ def constraintsName = "3.13".equals(project.ext.pythonVersion) ?
"constraints_py313.txt" : "constraints.txt"
Review Comment:
Ahh yes thast's a better approach, I refactored to use the single file
approach. constraints_py313.txt has been removed and Numpy is now specified in
setup.py (and pyproject.toml)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
