tvalentyn commented on code in PR #37685:
URL: https://github.com/apache/beam/pull/37685#discussion_r2843732615
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -3169,9 +3170,19 @@ class BeamModulePlugin implements Plugin<Project> {
packages += ",${extra}"
}
+ def pythonSdkDir = project.project(":sdks:python").projectDir
+ def constraintsPath = "${pythonSdkDir}/constraints.txt"
+ def constraintFile = project.file(constraintsPath)
+ def constraintFlag = constraintFile.exists() ? "--constraint
${constraintsPath}" : ""
+
+ // Use uv instead of pip - pip was hitting resolution-too-deep on
tensorflow->keras->namex/optree.
+ // Include namex/optree as explicit deps to constrain resolution.
+ // --prerelease allow: envoy-data-plane depends on
betterproto==2.0.0b6 (beta).
+ def anchorPkgs = "namex==0.0.9 optree==0.16.0"
Review Comment:
I think these deps are specific to a certain test suite, and thus
configuring them is a matter of the test suite that needs them;
BeamModulePlugin should concern with global configuration matters for the
project; adding these deps doesn't feel like the right direction to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
