tvalentyn commented on code in PR #37685:
URL: https://github.com/apache/beam/pull/37685#discussion_r2843740486
##########
sdks/python/pyproject.toml:
##########
@@ -26,8 +26,9 @@ requires = [
"mypy-protobuf==3.5.0",
# Avoid https://github.com/pypa/virtualenv/issues/2006
"distlib==0.3.9",
- # Numpy headers
- "numpy>=1.14.3,<2.5.0", # Update setup.py as well.
+ # Numpy headers. py313 requires 2.1+; py<3.13 use 1.x for pandas ABI
compat.
Review Comment:
I don't follow why we need to cap numpy to `< 2` for Python 3.10-3.12.
`<2.5.0` seems like a wide enough bound , and i'd expect each python version
to pick the right version that is compatible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
