junaiddshaukat commented on PR #37705:
URL: https://github.com/apache/beam/pull/37705#issuecomment-3957755010
> It's deleting functioning metrics and codes. Please check generated code
changes before pushing PRs
Thanks for the feedback, you were right that I accidentally removed existing
metrics and related code in my initial change.
I’ve updated the branch to:
- Restore KafkaMetrics, KafkaSinkMetrics, and their tests so no existing
metrics or code are deleted anymore.
- Keep the intended optimization for #37704, which removes the Guava
Stopwatch/System.nanoTime() calls from the hot consumer.poll() loop and uses
System.currentTimeMillis() for timeout tracking instead.
I’ve re-run ./gradlew :sdks:java:io:kafka:test locally and it passes.
Please take another look and let me know if you’d like me to narrow or
adjust the change further. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
