Abacn commented on code in PR #37705:
URL: https://github.com/apache/beam/pull/37705#discussion_r2853704600
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaDoFn.java:
##########
@@ -567,19 +566,14 @@ public ProcessContinuation processElement(
long expectedOffset = tracker.currentRestriction().getFrom();
consumer.resume(Collections.singleton(topicPartition));
consumer.seek(topicPartition, expectedOffset);
- final Stopwatch pollTimer = Stopwatch.createUnstarted();
final KafkaMetrics kafkaMetrics = KafkaSinkMetrics.kafkaMetrics();
try {
while (Duration.ZERO.compareTo(remainingTimeout) < 0) {
- // TODO: Remove this timer and use the existing fetch-latency-avg
metric.
Review Comment:
The TODO is still valid. It's referring to Kafka metrics:
https://kafka.apache.org/20/generated/consumer_metrics.html
Stopwatch and System.currentTimeMillis doesn't make a difference here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
