arunpandianp commented on code in PR #37574:
URL: https://github.com/apache/beam/pull/37574#discussion_r3240535249
##########
runners/core-java/src/main/java/org/apache/beam/runners/core/triggers/TriggerStateMachineRunner.java:
##########
@@ -180,13 +195,23 @@ public void onFire(W window, Timers timers,
StateAccessor<?> state) throws Excep
persistFinishedSet(state, finishedSet);
}
- private void persistFinishedSet(
- StateAccessor<?> state, FinishedTriggersBitSet modifiedFinishedSet) {
+ @VisibleForTesting
+ void persistFinishedSet(StateAccessor<?> state, FinishedTriggersBitSet
modifiedFinishedSet) {
if (!isFinishedSetNeeded()) {
return;
}
ValueState<BitSet> finishedSetState = state.access(FINISHED_BITS_TAG);
+
+ if (useNewWindowOptimization) {
+ @Nullable BitSet bitSet = finishedSetState.read();
+ if (bitSet == null || !bitSet.equals(modifiedFinishedSet.getBitSet())) {
+ // Write a value even if the bitset was empty
+ finishedSetState.write(modifiedFinishedSet.getBitSet());
+ }
+ return;
+ }
+
if (!readFinishedBits(finishedSetState).equals(modifiedFinishedSet)) {
Review Comment:
Note: before this PR this check always returned true due to equals method
missing in FinishedTriggersBitSet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
