arunpandianp commented on code in PR #37574:
URL: https://github.com/apache/beam/pull/37574#discussion_r3240565067
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/state/WindmillWatermarkHold.java:
##########
@@ -133,48 +148,71 @@ public Future<Windmill.WorkItemCommitRequest> persist(
Future<Windmill.WorkItemCommitRequest> result;
- if (!cleared && localAdditions == null) {
+ if (!knownEmpty && !cleared && localAdditions == null) {
// No changes, so no need to update Windmill and no need to cache any
value.
return
Futures.immediateFuture(Windmill.WorkItemCommitRequest.newBuilder().buildPartial());
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
