scwhittle commented on code in PR #37574:
URL: https://github.com/apache/beam/pull/37574#discussion_r3258192374
##########
runners/core-java/src/main/java/org/apache/beam/runners/core/ReduceFnRunner.java:
##########
@@ -613,6 +642,18 @@ private void processElement(Map<W, W> windowToMergeResult,
WindowedValue<InputT>
StateStyle.RENAMED,
value.causedByDrain());
+ // TODO: Make sure the NewWindowOptimization does not create unbounded
trigger state
+ // in GlobalWindow
+ if (useNewWindowOptimization &&
triggerRunner.isNew(directContext.state())) {
+ // Blindly clear state to ensure Windmill doesn't do unnecessary reads.
Review Comment:
are these clears going to cause deletes that we don't need? could put a
to-do as a further improvement to add way to set them known empty instead of
clearing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
