shunping commented on code in PR #39161:
URL: https://github.com/apache/beam/pull/39161#discussion_r3651420290
##########
sdks/python/apache_beam/runners/interactive/recording_manager.py:
##########
Review Comment:
How about we make a new helper function and use it here and below?
```python
def _get_uncomputed_pcolls(self, pcolls) -> set:
"""Helper to filter out already computed PCollections from the
environment."""
current_env = ie.current_env()
computed = {
pcoll for pcoll in pcolls
if pcoll in current_env.computed_pcollections
}
return set(pcolls).difference(computed)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
