ian-Liaozy commented on code in PR #39161:
URL: https://github.com/apache/beam/pull/39161#discussion_r3554138005
##########
sdks/python/apache_beam/runners/interactive/recording_manager.py:
##########
@@ -151,27 +152,32 @@ def exception(self, timeout=None):
except TimeoutError:
return None
- def _on_done(self, future: Future):
- self._env.unmark_pcollection_computing(self._pcolls)
- self._recording_manager._async_computations.pop(self._display_id, None)
-
- if future.cancelled():
- self.update_display('Computation Cancelled.', 1.0)
- return
+ def wait_for_completion(self):
+ self._completed_event.wait()
- exc = future.exception()
- if exc:
- self.update_display(f'Error: {exc}', 1.0)
- _LOGGER.error('Asynchronous computation failed: %s', exc, exc_info=exc)
- else:
- self.update_display('Computation Finished Successfully.', 1.0)
- res = future.result()
- if res and res.state == PipelineState.DONE:
- self._env.mark_pcollection_computed(self._pcolls)
+ def _on_done(self, future: Future):
+ try:
+ if future.cancelled():
+ self.update_display('Computation Cancelled.', 1.0)
+ return
+
+ exc = future.exception()
+ if exc:
+ self.update_display(f'Error: {exc}', 1.0)
+ _LOGGER.error('Asynchronous computation failed: %s', exc, exc_info=exc)
else:
- _LOGGER.warning(
- 'Async computation finished but state is not DONE: %s',
- res.state if res else 'Unknown')
+ self.update_display('Computation Finished Successfully.', 1.0)
+ res = future.result()
+ if res and res.state == PipelineState.DONE:
+ self._env.mark_pcollection_computed(self._pcolls)
+ else:
+ _LOGGER.warning(
+ 'Async computation finished but state is not DONE: %s',
+ res.state if res else 'Unknown')
+ finally:
+ self._env.unmark_pcollection_computing(self._pcolls)
+ self._recording_manager._async_computations.pop(self._display_id, None)
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
