ian-Liaozy commented on code in PR #39161:
URL: https://github.com/apache/beam/pull/39161#discussion_r3554134672
##########
sdks/python/apache_beam/runners/interactive/recording_manager.py:
##########
@@ -800,10 +799,15 @@ def _wait_for_dependencies(
"""Waits for any dependencies of the given
PCollections that are currently being computed."""
dependencies = self._get_all_dependencies(pcolls)
+ if async_result is None:
+ pcolls_to_check = dependencies.union(pcolls)
+ else:
+ pcolls_to_check = dependencies
computing_deps: dict[beam.pvalue.PCollection, AsyncComputationResult] = {}
- for dep in dependencies:
- if self._env.is_pcollection_computing(dep):
+ for dep in pcolls_to_check:
+ is_computing = self._env.is_pcollection_computing(dep)
+ if is_computing:
Review Comment:
fixed in current version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
