stankiewicz commented on code in PR #39612:
URL: https://github.com/apache/beam/pull/39612#discussion_r3802134031
##########
sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/write/UnboundedSolaceWriter.java:
##########
@@ -218,6 +230,37 @@ public void publishResults(BeamContextWrapper context) {
}
}
+ public void waitForAcks(BeamContextWrapper context, Set<String>
messageIdsToAck) {
+ BlockingQueue<PublishResult> queue =
+ solaceSessionServiceWithProducer().getPublishedResultsQueue();
+ long timeoutMs = System.currentTimeMillis() + ACKS_FLUSHING_INTERVAL_SECS
* 1000;
Review Comment:
so the tiny cost here will be cpu of worker on checking the queue. there is
no api rate limit issue as different thread is publishing to the queue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
