stankiewicz commented on PR #39612: URL: https://github.com/apache/beam/pull/39612#issuecomment-5450904923
> From my testing it looks OK so far, all input elements have an output element (Solace publishing result). > > I tested both in streaming pipelines and batch pipelines. > > I am only testing using the default writer type (`BATCHED`). Does it make sense to also test it with the `STREAMING` writer type? I think I will do that as in fact we might consider switching writer types at some point... will report back. Paweł, committed new version, it doesn't change too much, it's still stateful, but I've removed timer which wasn't needed as all ACKs are received and it was invalid for batch pipelines. Regarding STREAMING, it is waiting for ACK on finishBundle, similarly to BATCHED mode, you should see same improvement there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
