stankiewicz commented on code in PR #39612:
URL: https://github.com/apache/beam/pull/39612#discussion_r3879490298
##########
sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/write/UnboundedBatchedSolaceWriter.java:
##########
@@ -130,12 +139,16 @@ public void finishBundle(FinishBundleContext context)
throws IOException {
}
getCurrentBundle().clear();
- publishResults(BeamContextWrapper.of(context));
+ if (getDeliveryMode() == DeliveryMode.PERSISTENT && messageIdsToAck !=
null) {
+ waitForAcks(BeamContextWrapper.of(context), messageIdsToAck);
+ } else {
+ publishResults(BeamContextWrapper.of(context), null);
+ }
}
@OnTimer("bundle_flusher")
public void flushBundle(OnTimerContext context) throws IOException {
- publishResults(BeamContextWrapper.of(context));
+ publishResults(BeamContextWrapper.of(context), null);
Review Comment:
@chamikaramj I've removed timer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
