scwhittle commented on issue #35934: URL: https://github.com/apache/beam/issues/35934#issuecomment-5644881267
Sorry I was unclear. The problem is not due to the state cache itself but is due to caching of side inputs within dofninvokers (originally motivated by performance I believe). See files in https://github.com/apache/beam/pull/37123. I had a proposed fix to clear the DoFnInvoker cached window args between bundles, however without the overall state cache being enabled this would result in re-fetching side inputs from the runner for each bundle. This might have a negative impact on streaming performance in particular where bundles are generally short-lived. One option could be to just perform such clearing within dofninvoker if the state cache is enabled, and recommend customers enable that flag if they want to observe updated side inputs. Or we could rework the caching within dofninvoker to be shared across dofninvokers and refreshed periodically. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
