damccorm commented on issue #35934: URL: https://github.com/apache/beam/issues/35934#issuecomment-5681585512
This SGTM, with a couple of notes: > auto-enable the option if the side input cache is enabled We should definitely make this something that users can disable as an escape hatch for us if we regress this use case somehow. We should also make sure that this ends up in CHANGES.md > I believe there is not real guarantee about side-input refreshes in the beam model it is just best-effort in the dataflow runner by sprinkling cache timeouts around to handle side-inputs refreshing. A side-input observed for a window is always "valid" for that window from the model. I'm not sure how much this matters - if the expected behavior is unclear to some of us, and Latest.Globally doesn't actually give the latest element, I think its a bug. Can we document Latest.globally as part of this work? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
