scwhittle commented on issue #35934:
URL: https://github.com/apache/beam/issues/35934#issuecomment-5688760793

   > We should definitely make this something that users can disable as an 
escape hatch for us if we regress this use case somehow.
   
   Ack, I meant to say "change the default behavior if the state cache is 
enabled".  This would still let users manually override this option separately.
   
   > Latest.Globally doesn't actually give the latest element, I think its a 
bug.
   
   I agree it should be fixed too, which is why I put together those changes 
originally.
   But  I think `Latest.globally()` is perhaps a confusing name here, it is how 
to calculate the side input (latest value, it could just as easily be a 
`Count.globally()`).  The refreshing part is due to the triggering 
re-evaluating the side-input.  And there is not a guarantee on main inputs 
observing this  updated triggered value. Even once we fix this there will be 
some latency waiting for cache timeouts, it won't be the absolute `latest` 
value.  For example, if the side-input triggering specifies to refresh it every 
second, it would likely take at least a minute.  But this is still better than 
stuck on the original value forever :)
   
   I think a beam-native broadcast variable would be a better fit than 
refreshing global side inputs we currently have.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to