aIbrahiim commented on PR #40370: URL: https://github.com/apache/beam/pull/40370#issuecomment-5968607133
> The fix touches core codes of trigger, tagging people to review @kennknowles (Beam semantics) > > Also this test exists for long. While it started failing recently? And now requiring changing core code to fix it? The example has used AfterCount since 2017, and the passing run and the failing run were the same code so I think this did not break recently and it just fails when that trigger does not emit the row the test was looking for Dataflow already runs AfterProcessingTime and the change that fixes the IT is leader_board.py execution.py and trigger.py are only for the unit tests as after the example change, FnApi crashed because the trigger driver has no clock, and it fired the processing time timers immediately -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
