kennknowles commented on code in PR #40370:
URL: https://github.com/apache/beam/pull/40370#discussion_r4210955843
##########
sdks/python/apache_beam/examples/complete/game/leader_board.py:
##########
@@ -242,16 +241,14 @@ def __init__(self, allowed_lateness):
self.allowed_lateness_seconds = allowed_lateness * 60
def expand(self, pcoll):
- # NOTE: the behavior does not exactly match the Java example
- # TODO: allowed_lateness not implemented yet in FixedWindows
- # TODO: AfterProcessingTime not implemented yet, replace AfterCount
return (
pcoll
- # Get periodic results every ten events.
+ # Get periodic results every ten minutes.
| 'LeaderboardUserGlobalWindows' >> beam.WindowInto(
beam.window.GlobalWindows(),
- trigger=trigger.Repeatedly(trigger.AfterCount(10)),
- accumulation_mode=trigger.AccumulationMode.ACCUMULATING)
+ trigger=trigger.Repeatedly(trigger.AfterProcessingTime(10 * 60)),
Review Comment:
This one is still multiple minutes - let's make it seconds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
