kennknowles commented on code in PR #40370:
URL: https://github.com/apache/beam/pull/40370#discussion_r4196856853
##########
sdks/python/apache_beam/examples/complete/game/leader_board.py:
##########
@@ -212,18 +212,17 @@ def __init__(self, team_window_duration,
allowed_lateness):
self.allowed_lateness_seconds = allowed_lateness * 60
def expand(self, pcoll):
- # NOTE: the behavior does not exactly match the Java example
- # TODO: allowed_lateness not implemented yet in FixedWindows
- # TODO: AfterProcessingTime not implemented yet, replace AfterCount
return (
pcoll
# We will get early (speculative) results as well as cumulative
# processing of late data.
| 'LeaderboardTeamFixedWindows' >> beam.WindowInto(
beam.window.FixedWindows(self.team_window_duration),
trigger=trigger.AfterWatermark(
- trigger.AfterCount(10), trigger.AfterCount(20)),
- accumulation_mode=trigger.AccumulationMode.ACCUMULATING)
+ early=trigger.AfterProcessingTime(5 * 60),
Review Comment:
But this is 5 minutes which seems way too long.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
