prodriguezdefino commented on code in PR #40606:
URL: https://github.com/apache/beam/pull/40606#discussion_r4300044918
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/fn/data/BeamFnDataGrpcMultiplexer.java:
##########
@@ -93,6 +222,20 @@ public String toString() {
.toString();
}
+ /**
+ * Called when a bundle finishes one inbound message. Asks for more messages
until {@code
+ * STEADY_STATE_INBOUND_WINDOW} messages are open again.
+ */
+ public void requestInbound(int count) {
+ inFlightInbound.decrementAndGet();
Review Comment:
Fixed in b7532bb with `addAndGet(-count)`. `testRequestInboundReleasesCount`
opens three extra messages with `onStalledPoll()`, then releases five and
checks that two more are requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
