prodriguezdefino commented on code in PR #40606:
URL: https://github.com/apache/beam/pull/40606#discussion_r4300437928
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/fn/data/BeamFnDataInboundObserver.java:
##########
@@ -177,19 +200,28 @@ public void awaitCompletion() throws Exception {
// collection.
Review Comment:
Both fixed in 6f9d444.
The queued element is declared inside the scope block again, so nothing
outside it holds the `Elements` proto while `multiplexElements` runs, the
callback is kept separately.
The callback of the in-progress element is now released in finally, after
`close()`, so it covers every throwable.
- `testCallbacksInvokedOnConsumerError` has a consumer throw an
AssertionError and checks that both callbacks run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
