prodriguezdefino commented on code in PR #40606:
URL: https://github.com/apache/beam/pull/40606#discussion_r4300038675
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/fn/data/BeamFnDataGrpcMultiplexer.java:
##########
@@ -233,9 +404,12 @@ public void onNext(BeamFnApi.Elements value) {
}
}
if (instructionId == null) {
Review Comment:
Now the `computeIfAbsent` function returns null for a poisoned ID, so late
data inserts nothing and is dropped, and its permit is released.
`ReceiverHolder.complete()` also returns false for a poisoned holder, and
`registerConsumer` reports it as poisoned. `testPoisonInstructionId` now sends
late data after poisoning, checks that no entry remains, and checks that a
later registration throws `IllegalArgumentException`.
`testPermitsReleasedForLateDataOfPoisonedInstruction` checks the permits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
