Abacn commented on code in PR #40695:
URL: https://github.com/apache/beam/pull/40695#discussion_r4342342342
##########
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamSortRel.java:
##########
@@ -378,9 +378,16 @@ public int compare(Row row1, Row row2) {
if (isValue1Null && isValue2Null) {
continue;
} else if (isValue1Null && !isValue2Null) {
- fieldRet = -1 * (nullsFirst.get(i) ? -1 : 1);
+ // NULL placement is absolute: NULLS FIRST means the null row always
sorts before the
Review Comment:
changed to a one-line comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
