Abacn commented on code in PR #40695:
URL: https://github.com/apache/beam/pull/40695#discussion_r4342366210
##########
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamWindowRel.java:
##########
@@ -220,10 +277,12 @@ public NodeStats estimateNodeStats(BeamRelMetadataQuery
mq) {
*/
@Override
public BeamCostModel beamComputeSelfCost(RelOptPlanner planner,
BeamRelMetadataQuery mq) {
- NodeStats inputStat = BeamSqlRelUtils.getNodeStats(this.input, mq);
+ // Use the planner's row-count (RelSubset-safe) rather than
BeamSqlRelUtils.getNodeStats, which
Review Comment:
acked. This could be a future improvement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
