Abacn commented on code in PR #40695:
URL: https://github.com/apache/beam/pull/40695#discussion_r4342344958
##########
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamSortRel.java:
##########
@@ -389,9 +396,17 @@ public int compare(Row row1, Row row2) {
case BIGINT:
case FLOAT:
case DOUBLE:
+ case DECIMAL:
+ case BOOLEAN:
case VARCHAR:
+ case CHAR:
case DATE:
+ case TIME:
case TIMESTAMP:
+ // All of the above map to Java types that implement Comparable
(Boolean, BigDecimal,
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
