ahmedabu98 commented on code in PR #40817:
URL: https://github.com/apache/beam/pull/40817#discussion_r4392055987
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/AddFiles.java:
##########
@@ -304,14 +312,27 @@ public PCollectionRowTuple expand(PCollection<String>
input) {
throw new RuntimeException(e);
}
- PCollection<KV<Integer, SerializableDataFile>> keyedFiles =
+ PCollection<KV<KV<String, Integer>, SerializableDataFile>> keyedFiles =
Review Comment:
This breaks update and upgrade compatibility right?
I think it might be unavoidable, but please mention it in CHANGES.md
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/AddFiles.java:
##########
@@ -304,14 +312,27 @@ public PCollectionRowTuple expand(PCollection<String>
input) {
throw new RuntimeException(e);
}
- PCollection<KV<Integer, SerializableDataFile>> keyedFiles =
+ PCollection<KV<KV<String, Integer>, SerializableDataFile>> keyedFiles =
Review Comment:
nit: for this and below, can we use an Autovalue/Row type (containing
destination and specID) instead of `KV<String, Integer>`?
Will make it more readable and also give us flexibility to add more columns
in the future without breaking update compatibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
