claudevdm commented on code in PR #40817:
URL: https://github.com/apache/beam/pull/40817#discussion_r4392334572
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/AddFiles.java:
##########
@@ -304,14 +312,27 @@ public PCollectionRowTuple expand(PCollection<String>
input) {
throw new RuntimeException(e);
}
- PCollection<KV<Integer, SerializableDataFile>> keyedFiles =
+ PCollection<KV<KV<String, Integer>, SerializableDataFile>> keyedFiles =
Review Comment:
Sure will mention in CHANGES.md, but I don't think breaking update compat is
a big deal for AddFiles. It is a temporary migration transform that is highly
unlikely to be updated in place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
