ahmedabu98 commented on code in PR #40817:
URL: https://github.com/apache/beam/pull/40817#discussion_r4392401936
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/AddFiles.java:
##########
@@ -304,14 +312,27 @@ public PCollectionRowTuple expand(PCollection<String>
input) {
throw new RuntimeException(e);
}
- PCollection<KV<Integer, SerializableDataFile>> keyedFiles =
+ PCollection<KV<KV<String, Integer>, SerializableDataFile>> keyedFiles =
Review Comment:
We're turning it into a Managed transform
(https://github.com/apache/beam/pull/40827) so will also need to be wary of
upgrade incompatible changes (e.g. a graph change from 2.77 to upgraded 2.79)
The current multi-table changes should be fine though, since Managed
transform will come in 2.78 too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
