pabloem commented on a change in pull request #13055:
URL: https://github.com/apache/beam/pull/13055#discussion_r502683454
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java
##########
@@ -2002,6 +2006,11 @@ static String getExtractDestinationUri(String
extractDestinationDir) {
return toBuilder().setFormatFunction(formatFunction).build();
}
+ /** Formats the user's type into a {@link TableRow} to be written to an
error collector. */
+ public Write<T> withFailsafeFormatFunction(SerializableFunction<T,
TableRow> formatFunction) {
Review comment:
Does this have to write TableRows? Why not also have the option to
return the user type itself? (perhaps it's a lot of trouble to implement given
the existing types?)
What are some examples where users may want to recover a different tablerow
than the one that was sent to BQ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
