dhercher commented on a change in pull request #13055:
URL: https://github.com/apache/beam/pull/13055#discussion_r502701806
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java
##########
@@ -2002,6 +2006,11 @@ static String getExtractDestinationUri(String
extractDestinationDir) {
return toBuilder().setFormatFunction(formatFunction).build();
}
+ /** Formats the user's type into a {@link TableRow} to be written to an
error collector. */
+ public Write<T> withFailsafeFormatFunction(SerializableFunction<T,
TableRow> formatFunction) {
Review comment:
Currently the design is for the ErrorContainer to return TableRow's (or
BigQueryError<TableRow>). My worry is that it wouldn't be backwards compatible
to make this generic, though I agree it would be more valuable.
I think this question is important and is my only big open question around
this design
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
