kamilwu commented on pull request #13245: URL: https://github.com/apache/beam/pull/13245#issuecomment-721071164
Thanks. Two other notes: 1. Do you think you can add a unit test in `source_test.go` that would check your functionality? 2. Please do not squash review changes. It makes it hard for a reviewer to follow up with what has changed. Instead, create a commit like "fix: a short summary". Those commits are squashed after review is complete. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
