kamilwu commented on a change in pull request #13245:
URL: https://github.com/apache/beam/pull/13245#discussion_r517294852
##########
File path: sdks/go/pkg/beam/io/synthetic/source_test.go
##########
@@ -175,8 +175,8 @@ func TestSourceConfigBuilder_NumHotKeys(t *testing.T) {
{elms: 15, hotKeys: 2, hotKeyFraction: 1.0},
{elms: 30, hotKeys: 10, hotKeyFraction: 1.0},
{elms: 50, hotKeys: 25, hotKeyFraction: 1.0},
- {elms: 30, hotKeys: 10, hotKeyFraction: 0.5},
- {elms: 50, hotKeys: 25, hotKeyFraction: 0.75},
+ // {elms: 30, hotKeys: 10, hotKeyFraction: 0.5}, tests for
hotKeyFraction < 1.0 could be Flaky
Review comment:
In general, we shouldn't commit commented out code. That being said,
there are two solutions:
1) remove this completely,
2) if you feel that `hotKeyFraction` should be tested, but not necessarily
now for whatever reason, create a // TODO(BEAM-xxx) and describe what should be
done here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
