kamilwu commented on a change in pull request #13245:
URL: https://github.com/apache/beam/pull/13245#discussion_r517285596
##########
File path: sdks/go/pkg/beam/io/synthetic/source_test.go
##########
@@ -162,6 +164,83 @@ func TestSourceConfig_BuildFromJSON(t *testing.T) {
}
}
+// TestSourceConfig_NumHotKeys tests that setting the number of hot keys
+// for a synthetic source works correctly.
+func TestSourceConfigBuilder_NumHotKeys(t *testing.T) {
+ tests := []struct {
+ elms int
+ hotKeys int
+ }{
+ {elms: 15, hotKeys: 2},
+ {elms: 30, hotKeys: 10},
+ {elms: 50, hotKeys: 25},
+ }
+ for _, test := range tests {
+ test := test
+ t.Run(fmt.Sprintf("(elm = %v)", test.hotKeys), func(t
*testing.T) {
+ dfn := sourceFn{}
+ cfg := DefaultSourceConfig()
+ cfg.NumElements(test.elms)
+ cfg.HotKeyFraction(1.0)
+ cfg.NumHotKeys(test.hotKeys)
+
+ keys, _, err := simulateSourceFn(t, &dfn, cfg.Build())
+ if err != nil {
+ t.Errorf("Failure processing sourceFn: %v", err)
+ }
+
+ type val struct {
+ num int
+ isHotKey bool
+ }
+
+ m := make(map[string]val)
Review comment:
Yes, you're right, it should be a byte array. We can't use arrays/slices
as a key, but we can convert `[]byte` to `string`. You've already done this, so
this is good!
> However I'm a bit worried that testing HotKeyFraction could be Flaky, what
do you think?
Yes, there is some probability that this would happen unless we mock the
generator. Let's set `HotKeyFraction` to 1.0. Testing only `NumHotKeys` is fine
for me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
