apilloud commented on a change in pull request #13309:
URL: https://github.com/apache/beam/pull/13309#discussion_r525533663
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/SqlOperators.java
##########
@@ -158,7 +186,7 @@ public static SqlFunction createZetaSqlFunction(String
name, SqlTypeName returnT
SqlFunctionCategory.USER_DEFINED_FUNCTION);
}
- private static SqlUserDefinedAggFunction createUdafOperator(
+ public static SqlUserDefinedAggFunction createUdafOperator(
Review comment:
This (and `createUdfOperator`) is intended to be a (slightly hacky)
helper function for implementing ZetaSQL operators via the UDF interface. Why
do you need to make them public?
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/SqlOperators.java
##########
@@ -177,26 +205,25 @@ private static SqlUserDefinedFunction createUdfOperator(
Class<?> methodClass,
String methodName,
SqlReturnTypeInference returnTypeInference,
- List<RelDataType> paramTypes) {
+ List<RelDataType> paramTypes,
+ String funGroup) {
Review comment:
nit: It seems like `SqlAnalyzer.ZETASQL_FUNCTION_GROUP_NAME` is the only
thing ever passed to `funGroup` here and below. Should it really be an argument?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
