ibzib commented on a change in pull request #13309:
URL: https://github.com/apache/beam/pull/13309#discussion_r527359663
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/SqlOperators.java
##########
@@ -158,7 +186,7 @@ public static SqlFunction createZetaSqlFunction(String
name, SqlTypeName returnT
SqlFunctionCategory.USER_DEFINED_FUNCTION);
}
- private static SqlUserDefinedAggFunction createUdafOperator(
+ public static SqlUserDefinedAggFunction createUdafOperator(
Review comment:
In the original PR, I used createUdfOperator in ExpressionConverter, and
createUdafOperator in AggregateScanConverter. So they can be package-private
instead of public.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
