ibzib commented on a change in pull request #13309:
URL: https://github.com/apache/beam/pull/13309#discussion_r527360048



##########
File path: 
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/SqlOperators.java
##########
@@ -177,26 +205,25 @@ private static SqlUserDefinedFunction createUdfOperator(
       Class<?> methodClass,
       String methodName,
       SqlReturnTypeInference returnTypeInference,
-      List<RelDataType> paramTypes) {
+      List<RelDataType> paramTypes,
+      String funGroup) {

Review comment:
       The full implementation uses the group name to distinguish built-in 
functions from user-defined functions. (Whether that's a good idea or not is up 
for debate.)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to