TheNeuralBit commented on pull request #13410: URL: https://github.com/apache/beam/pull/13410#issuecomment-752698729
> I don't know how checkstyle works, but I can try to figure it out! If you have the bandwidth it would be great to do it as part of this PR! It could be left as a follow-up if you don't though. We'd probably want to add another entry like this one, but with a regex for `Charset.defaultCharset()`: https://github.com/apache/beam/blob/245cf2b8ccdca6b66269b4e473c1a8903631cb3f/sdks/java/build-tools/src/main/resources/beam/checkstyle.xml#L114-L120 You can test it out locally by running `./gradlew checkstyleMain checkstyleTest` Since there are some rare cases where we need the default charset we'll need to be able to suppress the check. Based on https://stackoverflow.com/questions/27688426/ignoring-of-checkstyle-warnings-with-annotation-suppresswarnings it looks like this can be done with `@SuppressWarnings` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
