y1chi commented on a change in pull request #13421:
URL: https://github.com/apache/beam/pull/13421#discussion_r538822955



##########
File path: sdks/python/apache_beam/transforms/userstate.py
##########
@@ -184,29 +186,6 @@ def to_runner_api(self, context, key_coder, window_coder):
             coders._TimerCoder(key_coder, window_coder)))
 
 
-# TODO(BEAM-9602): Provide support for dynamic timer.
-class TimerFamilySpec(object):

Review comment:
       Theoretically it should not supported to use same TimerSpec for 
different DoFnParam so I'm less worried about collision, if it is not apparent 
to user we can also add validation checks.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to