boyuanzz commented on a change in pull request #13421:
URL: https://github.com/apache/beam/pull/13421#discussion_r540587593
##########
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner_test.py
##########
@@ -493,6 +493,30 @@ def is_buffered_correctly(actual):
assert_that(actual, is_buffered_correctly)
+ def test_pardo_dynamic_timer(self):
+ class DynamicTimerDoFn(beam.DoFn):
+ dynamic_timer_spec = userstate.TimerSpec(
+ 'dynamic_timer', userstate.TimeDomain.WATERMARK)
+
+ def process(
+ self, element,
+ dynamic_timer=beam.DoFn.TimerParam(dynamic_timer_spec)):
+ dynamic_timer.set(element[1], dynamic_timer_tag=element[0])
Review comment:
Can we also test:
```python
dynamic_timer.set(timestamp)
dynamic_timer.set(timestamp, dynamic_timer_tag='')
```
here, where the later one should override the first one?
##########
File path: sdks/python/scripts/generate_pydoc.sh
##########
@@ -188,6 +188,7 @@ ignore_identifiers = [
# DoFn param inner classes, due to a Sphinx misparsing of inner classes
'_StateDoFnParam',
'_TimerDoFnParam',
+ '_TimerFamilyDoFnParam',
Review comment:
Remove this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
