y1chi commented on a change in pull request #13421:
URL: https://github.com/apache/beam/pull/13421#discussion_r538844975
##########
File path: sdks/python/apache_beam/transforms/userstate.py
##########
@@ -184,29 +186,6 @@ def to_runner_api(self, context, key_coder, window_coder):
coders._TimerCoder(key_coder, window_coder)))
-# TODO(BEAM-9602): Provide support for dynamic timer.
-class TimerFamilySpec(object):
Review comment:
My main consideration is that the DoFnParam here implies the API, e.g.
if using `a_timer=DoFn.TimerParam(timer_spec)` it translate to the old timer,
if using `a_timer=DoFn.TimerFamilyParam(timer_spec`) it translates to a dynamic
timer with which user can call `.get('tag').set()`, as for the timer spec it's
main purpose is just to specify the name and time domain, eventually they are
all mapped to
https://github.com/apache/beam/blob/master/model/pipeline/src/main/proto/beam_runner_api.proto#L542,
since we only have one model for the timer spec in beam runner api, I think
there's also some advantages to just using one kind of timer spec in sdk.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
