emilymye commented on a change in pull request #13517:
URL: https://github.com/apache/beam/pull/13517#discussion_r541227657
##########
File path: sdks/go/container/build.gradle
##########
@@ -47,12 +47,14 @@ golang {
}
}
+def defaultTag = project.rootProject.hasProperty(["docker-tag"]) ?
[project.rootProject["docker-tag"], 'latest'] : ['latest']
Review comment:
By default this will always push latest tag, which I'm not sure we
actually want to force. Would it be better to make docker-tag a comma-separated
string list parameter and use split? That way we can also allow people to push
more than one tag that isn't just latest.
##########
File path: .test-infra/jenkins/job_Publish_SDK_Image_Snapshots.groovy
##########
@@ -41,12 +41,12 @@ job('beam_Publish_Beam_SDK_Snapshots') {
gradle {
rootBuildScriptDir(commonJobProperties.checkoutDir)
commonJobProperties.setGradleSwitches(delegate)
- tasks(':sdks:go:container:dockerPush')
+ tasks(':sdks:go:container:dockerTagPush')
SUPPORTED_JAVA_CONTAINER_TASKS.each { taskVer ->
- tasks(":sdks:java:container:${taskVer}:dockerPush")
+ tasks(":sdks:java:container:${taskVer}:dockerTagPush")
Review comment:
awesome, I didn't know this existed! thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
