ihji commented on a change in pull request #13517:
URL: https://github.com/apache/beam/pull/13517#discussion_r541342375
##########
File path: sdks/go/container/build.gradle
##########
@@ -47,12 +47,14 @@ golang {
}
}
+def defaultTag = project.rootProject.hasProperty(["docker-tag"]) ?
[project.rootProject["docker-tag"], 'latest'] : ['latest']
Review comment:
Thanks for the comment.
> By default this will always push latest tag, which I'm not sure we
actually want to force.
FYI, 'latest' tag is only attached when we use `dockerTagPush` command (not
`dockerPush`).
If we allow a comma-separated string in `docker-tag`, it will break `docker`
task. `docker` and `dockerTag` are different commands where `docker` command
only works with the tag specified by `docker-tag` property but `dockerTag`
command respects the list of tags in `tags`.
We should define a separate property something like `docker-aux-tag` (or
`docker-secondary-tag`) and set `docker-tag` + `docker-aux-tag` for `tags` to
let users append their own tags. Do you want to go with this option?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
